-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage: tarpaulin / codecov #411
Conversation
I haven't done much with this except get tarpaulin to run, this is my first attempt to work on an issue as part of an open-source project so if I have missed the mark please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
This looks very good, check my comments, though.
It seems that you removed the Cargo.lock
file. This is not a big deal, it can be regenerated by running cargo update
.
We also don't need two workflows, so we don't need .github/workflows/coverage.yml
files.
If this is your first contribution to open source, congrats! keep them coming! :)
.github/workflows/rust.yml
Outdated
with: | ||
token: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to specify a token, since this is a public repository. This can be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this but it seems to still fail? Perhaps it is because I'm trying from my fork of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because we still don't have the project in CodeCov. Public repos shouldn't need a token.
Co-authored-by: Iban Eguia <razican@protonmail.ch>
This reverts commit f063e25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you modified the Cargo.lock
file. Could we avoid this? It's giving merge conflicts, but there should be no modification to that file :)
Done, sorry I thought I already removed it. |
Ok, let's wait for @jasonwilliams to see if we can have Boa in codecov so that this works :) |
I've now added the repo, give it a try and let us know |
Tried again but still codecov fails saying it needs a token |
@Lan2u could you try again? |
Tried again, the same result unfortunately :( |
I think it just needs to be initialized. We could try to merge this without the token and see if it works. |
Lets see what happens |
Perhaps related to https://community.codecov.io/t/github-public-repository-issues/1360? Will try and investigate further |
Seems to be fixed, Pull request #436 |
Relates to issue #378.
Added tarpaulin action to the test suite on Linux section of the CI, the produced report is then submitted to codecov.io. I used my own personal token for testing the codecov part but have removed it for this commit (it can be re-added into the actions file - this is why that stage currently fails).