Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FunctionDeclaration - execution] evaluate declaration into undefined not function #473

Merged
merged 5 commits into from
Jun 12, 2020
Merged

[FunctionDeclaration - execution] evaluate declaration into undefined not function #473

merged 5 commits into from
Jun 12, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jun 10, 2020 •
edited
Loading

Closes #454

@croraf croraf changed the title [FunctionDeclaration - executor] evaluate declaration into undefined not function [FunctionDeclaration - execution] evaluate declaration into undefined not function Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020 •
edited
Loading

Codecov Report

Merging #473 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   66.46%   66.47%           
=======================================
  Files         147      147           
  Lines        9408     9410    +2     
=======================================
+ Hits         6253     6255    +2     
  Misses       3155     3155
Impacted Files Coverage Δ
boa/src/builtins/value/tests.rs 100.00% <ø> (ø)
boa/src/exec/declaration/mod.rs 73.91% <100.00%> (ø)
boa/src/exec/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634dfb7...e4c7c5f. Read the comment docs.

Razican
Razican approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me :) thanks for the contribution!

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Jun 10, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 10, 2020
@HalidOdat HalidOdat merged commit c42fcf1 into boa-dev:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Function declaration returns the function, it should return undefined
4 participants
@croraf @Razican @jasonwilliams @HalidOdat