Fix all Value operations and add unsigned shift right
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 68.10% 67.99% -0.12%
==========================================
Files 169 170 +1
Lines 9942 10322 +380
==========================================
+ Hits 6771 7018 +247
- Misses 3171 3304 +133
Continue to review full report at Codecov.
|
Benchmark for 62e6586Click to view benchmark
|
Benchmark for e586af4Click to view benchmark
|
I would move it. It makes sense having everything that's related working similarly and having the same endpoint. If not, it could get a bit messy. |
Razican
reviewed
Jun 25, 2020
Benchmark for 5536c64Click to view benchmark
|
This is needed because the operations need context and in certain cases they can throw, so we need to support it.
- Added tests.
- Optimized `to_uint32` and `to_int32`.
HalidOdat
force-pushed
the
deprecate/value-to-conversions
branch
from
932ba10
to
036c7d1
Compare
Benchmark for 5f3389eClick to view benchmark
|
Benchmark for aceb394Click to view benchmark
|
Benchmark for 6d6afb9Click to view benchmark
|
Benchmark for a5c1d76Click to view benchmark
|
HalidOdat
changed the title
Values to_ conversions methodsValue operations
HalidOdat
changed the title
Value operationsValue operations and add unsigned shift right
|
This PR fixes all The This PR is ready, it would be nice to have fully working operators in |
Benchmark for efe1953Click to view benchmark
|
This was referenced Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem with the current implementation of
Values operations?The problem is that they are not spec compliant for objects, for example
ToNumber(to_number) for objects it is supposed to callto_primitiveand because it does not the codenew Number(6) + 3is broken and does not give the expected output9. Also becauseto_numberis called byValues operators, this means that theValueoperations can throw exceptions and it requires context and should return aResultValue.It changes the following:
Value::is_true()(this is a duplicate ofto_boolean)to_int32,to_uint32andto_lengthtoInterpreterto_integerspec compliantValueoperators => functions (these functions take in anInterpreter, and can throw in certain cases, see example)Valueoperations spec compliant.ValueoperationsThe below code is fixed with this PR:
I'm not sure if I should move
to_booleantoInterpreter, because it's the only one that can't throw and does not need context