Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the rest of the math methods #523

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

n14little
Copy link
Contributor

This Pull Request fixes/closes #514

It changes the following:

  • Refactors the following methods:
    • Math::atan2
    • Math::log
    • Math::log10
    • Math::log2
    • Math::min
    • Math::pow
    • Math::sign

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #523 into master will decrease coverage by 0.03%.
The diff coverage is 60.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   68.09%   68.05%   -0.04%     
==========================================
  Files         169      169              
  Lines        9925     9932       +7     
==========================================
+ Hits         6758     6759       +1     
- Misses       3167     3173       +6     
Impacted Files Coverage Δ
boa/src/builtins/math/mod.rs 76.07% <60.46%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24418e7...8c25d4d. Read the comment docs.

boa/src/builtins/math/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/math/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics performance Performance related changes and issues technical debt labels Jun 24, 2020
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 24, 2020
@Razican Razican merged commit 3fe8942 into boa-dev:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics performance Performance related changes and issues technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Math methods
3 participants