Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test + fmt fix #646

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Test + fmt fix #646

merged 2 commits into from
Aug 20, 2020

Conversation

Lan2u
Copy link

@Lan2u Lan2u commented Aug 19, 2020

The last few PR's introduced a failing test + a rust fmt issue.

Note the 'as u128' is because usize cannot fit the value 100000000000 in all environments.

This should fix both but I'm a little unsure about the test so it would be great if you could check it @HalidOdat ?

@Lan2u Lan2u requested a review from HalidOdat August 19, 2020 22:52
@Lan2u Lan2u added bug Something isn't working test Issues and PRs related to the tests. labels Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #646 into master will increase coverage by 1.24%.
The diff coverage is 77.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   71.25%   72.50%   +1.24%     
==========================================
  Files         176      179       +3     
  Lines       11557    13376    +1819     
==========================================
+ Hits         8235     9698    +1463     
- Misses       3322     3678     +356     
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 22.58% <0.00%> (-0.76%) ⬇️
boa/src/environment/function_environment_record.rs 27.08% <ø> (ø)
boa/src/environment/global_environment_record.rs 27.95% <0.00%> (ø)
boa/src/syntax/ast/op.rs 9.19% <0.00%> (-0.11%) ⬇️
boa/src/syntax/ast/punctuator.rs 2.10% <0.00%> (-0.03%) ⬇️
boa_cli/src/helper.rs 0.00% <0.00%> (ø)
boa_cli/src/main.rs 33.33% <ø> (+27.45%) ⬆️
boa_wasm/src/lib.rs 0.00% <0.00%> (ø)
boa/src/builtins/error/mod.rs 32.00% <12.50%> (-4.37%) ⬇️
boa/src/builtins/object/iter.rs 14.14% <14.14%> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f7374...bd94caa. Read the comment docs.

@github-actions
Copy link

Benchmark for 6e2684e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 384.7±11.47ns 385.9±10.18ns -0.31%
Arithmetic operations (Full) 265.3±9.53µs 246.5±6.73µs +7.63%
Array access (Execution) 8.4±0.26µs 8.2±0.17µs +2.44%
Array access (Full) 288.4±13.60µs 265.9±10.28µs +8.46%
Array creation (Execution) 3.5±0.09ms 3.4±0.09ms +2.94%
Array creation (Full) 4.0±0.13ms 3.8±0.10ms +5.26%
Array pop (Execution) 1245.1±46.85µs 1240.6±54.50µs +0.36%
Array pop (Full) 1650.4±38.89µs 1615.0±42.26µs +2.19%
Boolean Object Access (Execution) 4.8±0.16µs 4.7±0.14µs +2.13%
Boolean Object Access (Full) 276.5±6.83µs 257.7±5.25µs +7.30%
Create Realm 473.8±13.81ns 461.4±6.76ns +2.69%
Dynamic Object Property Access (Execution) 5.5±0.12µs 5.4±0.12µs +1.85%
Dynamic Object Property Access (Full) 281.8±62.04µs 260.0±5.24µs +8.38%
Expression (Lexer) 2.3±0.09µs 2.3±0.04µs 0.00%
Expression (Parser) 5.4±0.10µs 5.4±0.26µs 0.00%
Fibonacci (Execution) 811.8±14.26µs 814.3±10.07µs -0.31%
Fibonacci (Full) 1149.6±36.26µs 1093.9±27.96µs +5.09%
For loop (Execution) 23.3±2.10µs 22.7±0.55µs +2.64%
For loop (Full) 304.5±20.84µs 279.5±7.19µs +8.94%
For loop (Lexer) 4.1±0.07µs 4.1±0.07µs 0.00%
For loop (Parser) 12.3±0.13µs 12.2±0.37µs +0.82%
Goal Symbols (Parser) 8.5±0.15µs 8.5±0.28µs 0.00%
Hello World (Lexer) 839.5±22.23ns 858.9±19.00ns -2.26%
Hello World (Parser) 2.3±0.06µs 2.2±0.03µs +4.55%
Long file (Parser) 6.3±0.08ms 6.4±0.10ms -1.56%
Number Object Access (Execution) 3.7±0.09µs 3.8±0.18µs -2.63%
Number Object Access (Full) 272.6±5.33µs 252.4±5.88µs +8.00%
Object Creation (Execution) 4.8±0.28µs 4.6±0.08µs +4.35%
Object Creation (Full) 334.3±11.77µs 310.4±9.10µs +7.70%
RegExp (Execution) 65.8±1.99µs 65.5±1.32µs +0.46%
RegExp (Full) 430.9±20.86µs 405.7±7.61µs +6.21%
RegExp Literal (Execution) 69.4±2.04µs 69.3±1.99µs +0.14%
RegExp Literal (Full) 358.4±9.90µs 330.5±6.32µs +8.44%
RegExp Literal Creation (Execution) 66.9±3.71µs 65.6±1.29µs +1.98%
RegExp Literal Creation (Full) 439.7±5.42µs 406.0±9.30µs +8.30%
Static Object Property Access (Execution) 4.9±0.13µs 4.9±0.21µs 0.00%
Static Object Property Access (Full) 281.2±8.02µs 257.2±8.31µs +9.33%
String Object Access (Execution) 7.0±0.26µs 6.9±0.13µs +1.45%
String Object Access (Full) 280.9±11.54µs 263.1±4.85µs +6.77%
String comparison (Execution) 6.3±0.11µs 6.5±0.09µs -3.08%
String comparison (Full) 276.3±5.14µs 262.2±12.68µs +5.38%
String concatenation (Execution) 5.1±0.10µs 5.2±0.32µs -1.92%
String concatenation (Full) 275.2±9.94µs 255.8±5.01µs +7.58%
String copy (Execution) 3.9±0.06µs 3.9±0.12µs 0.00%
String copy (Full) 274.6±9.98µs 249.6±6.50µs +10.02%
Symbols (Execution) 3.2±0.06µs 3.2±0.04µs 0.00%
Symbols (Full) 255.7±10.11µs 235.0±2.99µs +8.81%

boa/src/exec/tests.rs Outdated Show resolved Hide resolved
@Razican Razican mentioned this pull request Aug 20, 2020
@Lan2u Lan2u merged commit 8ade420 into master Aug 20, 2020
@Lan2u Lan2u deleted the master_fixes branch August 20, 2020 07:48
@github-actions
Copy link

Benchmark for bde290d

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 390.7±11.00ns 394.0±19.52ns -0.84%
Arithmetic operations (Full) 263.0±12.17µs 259.4±9.99µs +1.39%
Array access (Execution) 8.6±0.28µs 8.6±0.45µs 0.00%
Array access (Full) 285.6±11.70µs 277.6±9.76µs +2.88%
Array creation (Execution) 3.6±0.08ms 3.7±0.10ms -2.70%
Array creation (Full) 3.9±0.07ms 4.0±0.24ms -2.50%
Array pop (Execution) 1351.5±141.08µs 1336.8±63.59µs +1.10%
Array pop (Full) 1686.9±64.52µs 1705.5±81.99µs -1.09%
Boolean Object Access (Execution) 5.1±0.16µs 4.9±0.29µs +4.08%
Boolean Object Access (Full) 270.4±10.15µs 272.6±12.37µs -0.81%
Create Realm 482.9±22.74ns 480.3±13.96ns +0.54%
Dynamic Object Property Access (Execution) 5.9±0.87µs 5.7±0.27µs +3.51%
Dynamic Object Property Access (Full) 276.8±13.47µs 271.8±16.72µs +1.84%
Expression (Lexer) 2.5±0.21µs 2.5±0.19µs 0.00%
Expression (Parser) 5.6±0.32µs 5.7±0.40µs -1.75%
Fibonacci (Execution) 839.4±36.22µs 843.0±29.85µs -0.43%
Fibonacci (Full) 1142.8±38.03µs 1125.2±36.34µs +1.56%
For loop (Execution) 23.5±0.98µs 23.7±0.92µs -0.84%
For loop (Full) 299.6±15.89µs 295.5±19.31µs +1.39%
For loop (Lexer) 4.5±0.16µs 4.4±0.12µs +2.27%
For loop (Parser) 12.7±0.30µs 12.8±0.26µs -0.78%
Goal Symbols (Parser) 8.9±0.45µs 8.8±0.33µs +1.14%
Hello World (Lexer) 893.4±29.09ns 886.7±37.73ns +0.76%
Hello World (Parser) 2.3±0.08µs 2.3±0.09µs 0.00%
Long file (Parser) 6.7±0.22ms 6.6±0.14ms +1.52%
Number Object Access (Execution) 4.0±0.15µs 3.9±0.37µs +2.56%
Number Object Access (Full) 268.9±7.28µs 270.6±12.71µs -0.63%
Object Creation (Execution) 4.8±0.17µs 4.8±0.23µs 0.00%
Object Creation (Full) 325.4±9.35µs 328.0±13.18µs -0.79%
RegExp (Execution) 70.1±3.20µs 71.7±5.12µs -2.23%
RegExp (Full) 429.9±20.26µs 431.1±20.17µs -0.28%
RegExp Literal (Execution) 74.0±3.41µs 74.4±4.69µs -0.54%
RegExp Literal (Full) 357.9±19.26µs 352.8±13.83µs +1.45%
RegExp Literal Creation (Execution) 70.3±3.67µs 70.9±3.91µs -0.85%
RegExp Literal Creation (Full) 424.5±11.11µs 441.2±28.59µs -3.79%
Static Object Property Access (Execution) 5.1±0.22µs 5.1±0.18µs 0.00%
Static Object Property Access (Full) 272.7±10.80µs 270.8±8.92µs +0.70%
String Object Access (Execution) 7.2±0.31µs 7.2±0.76µs 0.00%
String Object Access (Full) 274.1±13.93µs 273.0±14.93µs +0.40%
String comparison (Execution) 6.6±0.28µs 6.7±0.42µs -1.49%
String comparison (Full) 274.3±13.50µs 277.0±16.07µs -0.97%
String concatenation (Execution) 5.4±0.25µs 5.5±0.50µs -1.82%
String concatenation (Full) 269.0±6.98µs 264.9±17.41µs +1.55%
String copy (Execution) 4.0±0.14µs 4.0±0.15µs 0.00%
String copy (Full) 265.8±18.28µs 264.2±34.59µs +0.61%
Symbols (Execution) 3.3±0.11µs 3.3±0.13µs 0.00%
Symbols (Full) 248.7±8.48µs 250.3±9.30µs -0.64%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants