Move require_object_coercible to Value
#654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 179 179
Lines 13376 13376
=======================================
Hits 9698 9698
Misses 3678 3678
Continue to review full report at Codecov.
|
Benchmark for 2c02efdClick to view benchmark
|
Lan2u
approved these changes
Aug 21, 2020
HalidOdat
changed the title
Interpreter::require_object_coercible to Value::require_object_coerciblerequire_object_coercible to Value
Lan2u
pushed a commit
that referenced
this pull request
Aug 22, 2020
* Added CLEAN_JS and MINI_JS benches (#581) * Added CLEAN_JS and MINI_JS benches These benches are arbitrary code which is subject to change, functionally the programs are identical. * Forgot semicolon * Adding parsing benchmarks for CleanJS & MiniJS Added identical benchmark cases for parser. * Migrating Clean and Mini benchmarks to new format Adding js scripts in bench_scripts & moving exec, full and parser benchmarks to new include_str!() macro. * Move `require_object_coercible` to `Value` (#654) Co-authored-by: neeldug <5161147+neeldug@users.noreply.github.com> Co-authored-by: HalidOdat <halidodat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I missed when I was moving the methods in #625 , like
to_string()this is a value operation so it belongs inValue.It changes the following:
Interpreter::require_object_coercibletoValue::require_object_coercible