-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GcObject::contruct
not take 'this'
#660
Conversation
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 72.50% 72.55% +0.05%
==========================================
Files 179 179
Lines 13376 13374 -2
==========================================
+ Hits 9698 9704 +6
+ Misses 3678 3670 -8
Continue to review full report at Codecov.
|
Benchmark for 9cc6700Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It changes the following:
GcObject::contruct()
to take'this'
since it constructs it.