Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GcObject::contruct not take 'this' #660

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • It does not make sense for GcObject::contruct() to take 'this' since it constructs it.

@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Aug 25, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #660 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   72.50%   72.55%   +0.05%     
==========================================
  Files         179      179              
  Lines       13376    13374       -2     
==========================================
+ Hits         9698     9704       +6     
+ Misses       3678     3670       -8     
Impacted Files Coverage Δ
boa/src/builtins/object/gcobject.rs 73.87% <100.00%> (+1.14%) ⬆️
boa/src/exec/new/mod.rs 66.66% <100.00%> (-8.34%) ⬇️
boa/src/builtins/object/internal_methods.rs 41.97% <0.00%> (+4.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d7791...f251636. Read the comment docs.

@github-actions
Copy link

Benchmark for 9cc6700

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 289.8±18.18ns 303.1±16.72ns -4.39%
Arithmetic operations (Full) 192.6±14.32µs 205.6±13.52µs -6.32%
Array access (Execution) 6.2±0.32µs 6.3±0.42µs -1.59%
Array access (Full) 216.8±16.93µs 222.2±13.56µs -2.43%
Array creation (Execution) 2.6±0.11ms 2.5±0.08ms +4.00%
Array creation (Full) 2.9±0.13ms 3.4±0.19ms -14.71%
Array pop (Execution) 916.7±54.85µs 904.9±33.21µs +1.30%
Array pop (Full) 1219.9±57.78µs 1342.1±91.73µs -9.11%
Boolean Object Access (Execution) 3.7±0.34µs 4.1±0.38µs -9.76%
Boolean Object Access (Full) 198.7±9.36µs 212.1±17.70µs -6.32%
Clean js (Execution) 555.7±36.75µs 587.9±40.25µs -5.48%
Clean js (Full) 781.0±30.66µs 831.2±46.70µs -6.04%
Clean js (Parser) 19.8±1.65µs 19.2±1.45µs +3.13%
Create Realm 370.0±20.80ns 364.5±23.33ns +1.51%
Dynamic Object Property Access (Execution) 4.0±0.26µs 4.2±0.30µs -4.76%
Dynamic Object Property Access (Full) 204.3±13.11µs 223.8±19.22µs -8.71%
Expression (Lexer) 1772.3±73.81ns 1962.8±144.01ns -9.71%
Expression (Parser) 4.1±0.20µs 4.4±0.25µs -6.82%
Fibonacci (Execution) 595.9±22.02µs 611.3±31.40µs -2.52%
Fibonacci (Full) 815.1±34.49µs 892.8±62.10µs -8.70%
For loop (Execution) 16.7±0.80µs 17.5±1.25µs -4.57%
For loop (Full) 214.7±12.87µs 253.8±15.55µs -15.41%
For loop (Lexer) 3.4±0.45µs 3.4±0.22µs 0.00%
For loop (Parser) 9.8±0.86µs 10.1±0.66µs -2.97%
Goal Symbols (Parser) 6.4±0.35µs 6.7±0.41µs -4.48%
Hello World (Lexer) 646.9±24.70ns 708.3±107.64ns -8.67%
Hello World (Parser) 1671.8±84.27ns 1857.5±110.86ns -10.00%
Long file (Parser) 4.8±0.12ms 5.1±0.24ms -5.88%
Mini js (Execution) 505.8±34.24µs 552.3±40.08µs -8.42%
Mini js (Full) 719.7±35.41µs 761.7±44.56µs -5.51%
Mini js (Parser) 16.6±0.76µs 17.1±1.18µs -2.92%
Number Object Access (Execution) 2.8±0.10µs 2.8±0.14µs 0.00%
Number Object Access (Full) 194.4±13.07µs 206.8±16.40µs -6.00%
Object Creation (Execution) 3.4±0.18µs 3.5±0.16µs -2.86%
Object Creation (Full) 237.8±13.08µs 270.4±22.63µs -12.06%
RegExp (Execution) 50.8±2.59µs 51.0±5.18µs -0.39%
RegExp (Full) 320.5±21.95µs 378.0±24.94µs -15.21%
RegExp Literal (Execution) 53.0±3.17µs 54.3±3.09µs -2.39%
RegExp Literal (Full) 254.9±12.56µs 316.8±13.57µs -19.54%
RegExp Literal Creation (Execution) 50.6±2.89µs 50.6±2.79µs 0.00%
RegExp Literal Creation (Full) 310.9±14.23µs 367.7±29.57µs -15.45%
Static Object Property Access (Execution) 3.6±0.18µs 3.7±0.20µs -2.70%
Static Object Property Access (Full) 196.4±8.98µs 236.2±12.18µs -16.85%
String Object Access (Execution) 5.3±0.25µs 6.2±0.41µs -14.52%
String Object Access (Full) 198.8±9.50µs 221.8±13.66µs -10.37%
String comparison (Execution) 4.7±0.34µs 4.8±0.21µs -2.08%
String comparison (Full) 198.8±9.95µs 227.7±14.65µs -12.69%
String concatenation (Execution) 3.8±0.14µs 4.0±0.20µs -5.00%
String concatenation (Full) 197.8±14.17µs 220.6±15.80µs -10.34%
String copy (Execution) 2.9±0.14µs 2.9±0.13µs 0.00%
String copy (Full) 192.8±9.45µs 204.2±13.07µs -5.58%
Symbols (Execution) 2.4±0.15µs 2.4±0.11µs 0.00%
Symbols (Full) 181.0±8.38µs 189.5±18.28µs -4.49%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Lan2u Lan2u merged commit 4f5930c into master Aug 25, 2020
@HalidOdat HalidOdat deleted the fix/object-construct branch August 27, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants