Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy on Nightly #668

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Fix clippy on Nightly #668

merged 2 commits into from
Sep 25, 2020

Conversation

dvtkrlbs
Copy link

@dvtkrlbs dvtkrlbs commented Aug 30, 2020

This PR just fixes clippy

It changes the following:

  • It changes match blocks that returns booleans with two arms and if let blocks to the matches! macro

Ok i accidently tried this with nightly clippy and fixed a lint error for it. So this pr could be for nothing. But i can make it a draft PR and we can revisit it after this lint comes to the stable (if it ever does).

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #668 into master will increase coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
+ Coverage   71.76%   71.78%   +0.02%     
==========================================
  Files         199      199              
  Lines       13953    13943      -10     
==========================================
- Hits        10013    10009       -4     
+ Misses       3940     3934       -6     
Impacted Files Coverage Δ
boa/src/builtins/string/mod.rs 50.72% <0.00%> (-0.12%) ⬇️
boa/src/syntax/lexer/mod.rs 66.00% <0.00%> (-0.67%) ⬇️
boa/src/environment/lexical_environment.rs 75.00% <37.50%> (-0.50%) ⬇️
...tax/parser/expression/assignment/exponentiation.rs 85.00% <66.66%> (+4.04%) ⬆️
boa/src/environment/function_environment_record.rs 27.65% <100.00%> (+0.57%) ⬆️
boa/src/syntax/parser/expression/assignment/mod.rs 63.52% <100.00%> (+1.46%) ⬆️
boa/src/value/mod.rs 69.85% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7cd4c...0d50c41. Read the comment docs.

@Razican
Copy link
Member

Razican commented Aug 30, 2020

Also why clippy is not enabled on CI?

Isn't it? I thought we had an specific test, that's odd.

@dvtkrlbs
Copy link
Author

dvtkrlbs commented Aug 30, 2020

Oh there is. How come it was not failing for this lint ? Ok i am dumb i was running clippy on nightly and never tried it on stable.

@dvtkrlbs dvtkrlbs changed the title Fix clippy Fix clippy on Nightly Aug 30, 2020
Copy link

@Lan2u Lan2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but only once this is stable.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this as-is. The matches!() macro is already stable, it's the lint the only thing that is unstable, so merging this would future-proof the project. What do everyone else think?

@Razican Razican added the enhancement New feature or request label Sep 2, 2020
@Lan2u
Copy link

Lan2u commented Sep 25, 2020

I'm happy to merge this as-is. The matches!() macro is already stable, it's the lint the only thing that is unstable, so merging this would future-proof the project. What do everyone else think?

If @dvtkrlbs can resolve the merge conflict then I'm happy to merge this

@HalidOdat HalidOdat merged commit 01b5cec into boa-dev:master Sep 25, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants