Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Using the upstream version of the benchmark action" #781

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 3, 2020

Reverts #768. Until benchmark-action/github-action-benchmark#48 gets merged, let's revert this. I tried to generate a release of the action myself, but I was unable to do it.

@Razican Razican added bug Something isn't working benchmark Issues and PRs related to the benchmark subsystem. labels Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #781   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files         156      156           
  Lines        9820     9820           
=======================================
  Hits         5822     5822           
  Misses       3998     3998           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e60d2c...4cfdc06. Read the comment docs.

@Razican Razican added this to the v0.11.0 milestone Oct 3, 2020
@github-actions
Copy link

github-actions bot commented Oct 3, 2020

Benchmark for 2992289

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 351.9±29.21ns 352.7±20.16ns -0.23%
Arithmetic operations (Full) 261.8±17.92µs 294.1±16.88µs -10.98%
Array access (Execution) 8.4±0.46µs 8.1±0.45µs +3.70%
Array access (Full) 295.9±17.70µs 279.8±18.42µs +5.75%
Array creation (Execution) 3.2±0.17ms 3.1±0.18ms +3.23%
Array creation (Full) 3.4±0.14ms 3.3±0.17ms +3.03%
Array pop (Execution) 1101.4±82.78µs 1090.7±72.00µs +0.98%
Array pop (Full) 1575.9±64.76µs 1589.8±77.72µs -0.87%
Boolean Object Access (Execution) 4.9±0.24µs 5.0±0.29µs -2.00%
Boolean Object Access (Full) 269.4±15.66µs 309.1±25.85µs -12.84%
Clean js (Execution) 734.9±53.52µs 718.0±34.76µs +2.35%
Clean js (Full) 994.2±56.36µs 1167.1±80.66µs -14.81%
Clean js (Parser) 36.7±2.02µs 39.7±1.82µs -7.56%
Create Realm 483.5±20.16ns 452.8±31.87ns +6.78%
Dynamic Object Property Access (Execution) 5.5±0.32µs 5.5±0.41µs 0.00%
Dynamic Object Property Access (Full) 271.5±16.89µs 284.8±15.11µs -4.67%
Expression (Parser) 6.4±0.33µs 7.6±0.39µs -15.79%
Fibonacci (Execution) 869.8±44.68µs 852.4±42.56µs +2.04%
Fibonacci (Full) 1116.6±62.49µs 1084.9±57.40µs +2.92%
For loop (Execution) 22.4±1.46µs 23.1±3.70µs -3.03%
For loop (Full) 299.2±16.57µs 295.3±14.97µs +1.32%
For loop (Parser) 18.0±1.41µs 16.5±0.97µs +9.09%
Goal Symbols (Parser) 12.3±0.77µs 13.3±1.17µs -7.52%
Hello World (Parser) 3.0±0.25µs 3.5±0.21µs -14.29%
Long file (Parser) 790.0±40.12ns 752.0±31.85ns +5.05%
Mini js (Execution) 649.3±37.15µs 663.0±43.78µs -2.07%
Mini js (Full) 913.6±55.46µs 1074.8±71.69µs -15.00%
Mini js (Parser) 32.4±2.85µs 34.7±1.65µs -6.63%
Number Object Access (Execution) 3.8±0.19µs 3.9±0.20µs -2.56%
Number Object Access (Full) 262.8±12.34µs 303.7±10.52µs -13.47%
Object Creation (Execution) 4.7±0.86µs 4.7±0.42µs 0.00%
Object Creation (Full) 267.7±15.62µs 280.4±10.58µs -4.53%
RegExp (Execution) 66.6±3.73µs 73.1±5.67µs -8.89%
RegExp (Full) 350.4±19.69µs 355.4±23.94µs -1.41%
RegExp Literal (Execution) 71.2±4.10µs 76.4±4.73µs -6.81%
RegExp Literal (Full) 355.6±25.78µs 357.2±31.39µs -0.45%
RegExp Literal Creation (Execution) 68.1±5.10µs 70.8±5.91µs -3.81%
RegExp Literal Creation (Full) 356.7±29.18µs 344.7±25.42µs +3.48%
Static Object Property Access (Execution) 4.9±0.32µs 4.9±0.30µs 0.00%
Static Object Property Access (Full) 271.3±17.86µs 282.3±15.64µs -3.90%
String Object Access (Execution) 7.3±0.66µs 7.7±1.98µs -5.19%
String Object Access (Full) 275.6±18.96µs 334.2±26.25µs -17.53%
String comparison (Execution) 6.4±0.50µs 6.9±0.42µs -7.25%
String comparison (Full) 273.4±15.71µs 314.0±42.29µs -12.93%
String concatenation (Execution) 5.2±0.28µs 5.5±0.29µs -5.45%
String concatenation (Full) 263.7±14.34µs 306.9±28.16µs -14.08%
String copy (Execution) 3.9±0.20µs 4.1±0.31µs -4.88%
String copy (Full) 265.2±18.45µs 302.0±22.28µs -12.19%
Symbols (Execution) 3.2±0.19µs 3.3±0.19µs -3.03%
Symbols (Full) 263.5±16.83µs 262.7±22.28µs +0.30%

@HalidOdat HalidOdat merged commit b16f0ab into master Oct 3, 2020
@HalidOdat HalidOdat deleted the revert-768-fix_master_benches branch October 3, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants