Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PropertyDescriptor #794

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Refactor PropertyDescriptor #794

merged 6 commits into from
Oct 8, 2020

Commits on Oct 8, 2020

  1. Refactor PropertyDescriptor 

    - Add DataDescriptor
- Add AccessorDescriptor
- Remove PropertyDescriptor::data_descriptor()
- Make AccessorDescriptor accessors GcObjects
- Make Object::get_own_property return a Option<PropertyDescriptor>
- Remove PropertyDescriptor::is_none()
- Remove PropertyDescriptor::empty()
- Removed PropertyDescriptor::value()
- Added spec complaint ToPropertyDescriptor (to_property_descriptor)
- Remove From<&PropertyDescriptor> for Value
    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    37785af View commit details
    Browse the repository at this point in the history

  2. Made PropertyDescriptor and enum

    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    553a6e7 View commit details
    Browse the repository at this point in the history

  3. Added documentation

    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    642a2ad View commit details
    Browse the repository at this point in the history

  4. Remove Value::update_property

    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    fc334c8 View commit details
    Browse the repository at this point in the history

  5. Fix doc

    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    077a892 View commit details
    Browse the repository at this point in the history

  6. Remove .to_string()

    @HalidOdat
    HalidOdat committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    760e0f4 View commit details
    Browse the repository at this point in the history