-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Function.prototype
a function
#802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
enhancement
New feature or request
builtins
PRs and Issues related to builtins/intrinsics
labels
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 59.28% 59.35% +0.07%
==========================================
Files 155 155
Lines 9924 9945 +21
==========================================
+ Hits 5883 5903 +20
- Misses 4041 4042 +1
Continue to review full report at Codecov.
|
RageKnify
approved these changes
Oct 5, 2020
Benchmark for f30c6e4Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Function.prototype
is itself a function that has__proto__ == Object.prototype
. I Know this is very weirdIt changes the following:
Function.prototype
a function that returnundefined
Here is the spec: