-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using unstable sort for sorting keys on to_json()
for GC objects
#833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
performance
Performance related changes and issues
builtins
PRs and Issues related to builtins/intrinsics
labels
Oct 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 59.26% 59.26%
=======================================
Files 157 157
Lines 10035 10035
=======================================
Hits 5947 5947
Misses 4088 4088
Continue to review full report at Codecov.
|
HalidOdat
approved these changes
Oct 9, 2020
Benchmark for 17ac8bdClick to view benchmark
|
RageKnify
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builtins
PRs and Issues related to builtins/intrinsics
performance
Performance related changes and issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the clippy warning we were getting, and it might speed up things a bit. As far as I understand, there is no need to use stable sorting, right? Especially since we don't have two keys with the same name.