Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UnaryExpression with prefix increment/decrement #844

Merged

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 10, 2020

As per https://www.ecma-international.org/ecma-262/11.0/index.html#prod-UpdateExpression the right hand side of prefix increment/decrement can be an UnaryExpression and not just LeftHandSideExpression.

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #844 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   59.37%   59.36%   -0.01%     
==========================================
  Files         157      157              
  Lines       10036    10034       -2     
==========================================
- Hits         5959     5957       -2     
  Misses       4077     4077              
Impacted Files Coverage Δ
boa/src/syntax/parser/expression/update.rs 70.96% <100.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82dee1...150ad81. Read the comment docs.

@Lan2u Lan2u requested review from Razican and Lan2u and removed request for Razican October 10, 2020 22:25
@HalidOdat HalidOdat added bug Something isn't working parser Issues surrounding the parser labels Oct 11, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 11, 2020
@HalidOdat HalidOdat changed the title [parser UpdateExpression] allow UnaryExpression with prefix increment/decrement Allow UnaryExpression with prefix increment/decrement Oct 11, 2020
@HalidOdat HalidOdat merged commit 210a9ec into boa-dev:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants