Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cache in workflows #869

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Updated cache in workflows #869

merged 1 commit into from
Oct 14, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 14, 2020

This should simplify the workflow configuration, and the cache should now be more efficient. Hopefully will reduce build times a bit, since it also adds cache for MacOS and Windows builds.

This should simplify the workflow configuration, and the cache should
now be more efficient. Hopefully will reduce build times a bit.
@Razican Razican added enhancement New feature or request test Issues and PRs related to the tests. labels Oct 14, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #869 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files         164      164           
  Lines       10217    10217           
=======================================
  Hits         6033     6033           
  Misses       4184     4184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bea4f...bf452d7. Read the comment docs.

@github-actions
Copy link

Benchmark for db15f24

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 379.1±26.65ns 387.2±28.51ns -2.09%
Arithmetic operations (Full) 259.8±19.46µs 262.1±21.45µs -0.88%
Array access (Execution) 8.3±0.76µs 8.8±0.66µs -5.68%
Array access (Full) 296.5±22.28µs 282.6±19.80µs +4.92%
Array creation (Execution) 2.8±0.25ms 3.1±0.28ms -9.68%
Array creation (Full) 3.2±0.18ms 3.4±0.26ms -5.88%
Array pop (Execution) 1077.1±87.10µs 1104.1±106.55µs -2.45%
Array pop (Full) 1589.4±117.50µs 1606.7±133.19µs -1.08%
Boolean Object Access (Execution) 5.0±0.37µs 4.8±0.24µs +4.17%
Boolean Object Access (Full) 288.9±72.72µs 266.4±16.00µs +8.45%
Clean js (Execution) 766.1±55.52µs 764.8±48.74µs +0.17%
Clean js (Full) 1069.7±83.73µs 1105.8±75.72µs -3.26%
Clean js (Parser) 42.4±2.85µs 41.2±2.62µs +2.91%
Create Realm 493.3±44.81ns 509.9±33.25ns -3.26%
Dynamic Object Property Access (Execution) 6.7±1.18µs 5.9±0.30µs +13.56%
Dynamic Object Property Access (Full) 292.6±38.52µs 287.9±15.18µs +1.63%
Expression (Parser) 7.6±0.56µs 7.6±0.57µs 0.00%
Fibonacci (Execution) 906.0±74.05µs 919.2±49.78µs -1.44%
Fibonacci (Full) 1252.8±118.84µs 1239.2±87.75µs +1.10%
For loop (Execution) 24.7±2.08µs 25.5±2.25µs -3.14%
For loop (Full) 311.3±17.43µs 310.9±20.89µs +0.13%
For loop (Parser) 20.2±1.55µs 19.8±1.15µs +2.02%
Goal Symbols (Parser) 13.5±1.13µs 13.3±0.94µs +1.50%
Hello World (Parser) 3.4±0.26µs 3.4±0.25µs 0.00%
Long file (Parser) 880.6±71.59ns 848.7±69.12ns +3.76%
Mini js (Execution) 696.2±80.55µs 684.6±47.62µs +1.69%
Mini js (Full) 1010.2±85.34µs 993.2±65.24µs +1.71%
Mini js (Parser) 35.9±2.23µs 36.5±2.39µs -1.64%
Number Object Access (Execution) 4.1±0.54µs 3.8±0.28µs +7.89%
Number Object Access (Full) 286.0±21.27µs 273.4±19.63µs +4.61%
Object Creation (Execution) 5.4±0.36µs 5.4±0.34µs 0.00%
Object Creation (Full) 281.2±26.04µs 286.7±25.60µs -1.92%
RegExp (Execution) 10.7±0.85µs 10.1±0.71µs +5.94%
RegExp (Full) 283.5±24.73µs 295.8±19.13µs -4.16%
RegExp Literal (Execution) 11.5±0.84µs 11.6±0.82µs -0.86%
RegExp Literal (Full) 280.9±11.15µs 285.0±17.96µs -1.44%
RegExp Literal Creation (Execution) 10.3±0.96µs 10.0±0.61µs +3.00%
RegExp Literal Creation (Full) 280.0±28.42µs 289.6±19.32µs -3.31%
Static Object Property Access (Execution) 5.4±0.29µs 5.5±0.45µs -1.82%
Static Object Property Access (Full) 286.0±15.72µs 281.5±20.49µs +1.60%
String Object Access (Execution) 7.4±0.36µs 7.6±0.48µs -2.63%
String Object Access (Full) 276.8±18.67µs 281.4±23.71µs -1.63%
String comparison (Execution) 6.9±0.56µs 7.2±0.49µs -4.17%
String comparison (Full) 284.7±22.23µs 283.9±19.01µs +0.28%
String concatenation (Execution) 5.8±0.46µs 5.9±0.62µs -1.69%
String concatenation (Full) 292.9±18.68µs 291.5±27.34µs +0.48%
String copy (Execution) 4.6±0.28µs 4.4±0.26µs +4.55%
String copy (Full) 270.0±26.18µs 266.9±20.14µs +1.16%
Symbols (Execution) 3.6±0.29µs 3.6±0.18µs 0.00%
Symbols (Full) 256.1±20.75µs 250.4±14.96µs +2.28%

@Razican Razican merged commit 282e367 into master Oct 14, 2020
@Razican Razican deleted the improve_wf branch October 14, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants