Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cache from MacOS builds #873

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Removed cache from MacOS builds #873

merged 1 commit into from
Oct 14, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 14, 2020

It seems that MacOS builds were failing in PRs because somehow the cache doesn't work on MacOS builds in PRs. So let's remove it. It will take a bit longer to compile, but benchmarks and test262 are the bottleneck anyways.

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Oct 14, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         164      164           
  Lines       10209    10209           
=======================================
  Hits         6032     6032           
  Misses       4177     4177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7fe3f...73f3e80. Read the comment docs.

@github-actions
Copy link

Benchmark for 10d6efb

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 388.1±6.12ns 399.1±7.82ns -2.76%
Arithmetic operations (Full) 268.2±7.33µs 262.2±13.43µs +2.29%
Array access (Execution) 8.8±0.35µs 8.7±0.49µs +1.15%
Array access (Full) 295.8±31.43µs 286.8±8.20µs +3.14%
Array creation (Execution) 2.8±0.08ms 2.8±0.06ms 0.00%
Array creation (Full) 3.3±0.08ms 3.3±0.14ms 0.00%
Array pop (Execution) 1022.4±19.42µs 1030.2±23.90µs -0.76%
Array pop (Full) 1600.4±41.28µs 1594.6±43.08µs +0.36%
Boolean Object Access (Execution) 4.9±0.10µs 5.0±0.16µs -2.00%
Boolean Object Access (Full) 285.1±9.40µs 278.4±16.02µs +2.41%
Clean js (Execution) 753.6±27.23µs 749.7±14.84µs +0.52%
Clean js (Full) 1094.4±43.80µs 1076.4±22.88µs +1.67%
Clean js (Parser) 40.3±1.43µs 40.7±1.40µs -0.98%
Create Realm 485.3±16.22ns 480.8±9.92ns +0.94%
Dynamic Object Property Access (Execution) 6.3±0.15µs 6.3±0.15µs 0.00%
Dynamic Object Property Access (Full) 293.7±6.28µs 290.9±13.91µs +0.96%
Expression (Parser) 7.3±0.18µs 7.8±0.16µs -6.41%
Fibonacci (Execution) 961.7±25.19µs 956.1±21.56µs +0.59%
Fibonacci (Full) 1243.9±47.14µs 1254.6±40.16µs -0.85%
For loop (Execution) 25.0±0.76µs 24.3±0.50µs +2.88%
For loop (Full) 311.7±6.58µs 304.8±10.88µs +2.26%
For loop (Parser) 19.7±0.60µs 19.8±1.09µs -0.51%
Goal Symbols (Parser) 13.3±0.28µs 13.3±0.53µs 0.00%
Hello World (Parser) 3.5±0.06µs 3.6±0.25µs -2.78%
Long file (Parser) 842.7±29.77ns 846.2±22.48ns -0.41%
Mini js (Execution) 664.6±14.65µs 667.6±23.29µs -0.45%
Mini js (Full) 972.0±23.44µs 959.4±16.62µs +1.31%
Mini js (Parser) 35.4±1.23µs 35.6±1.08µs -0.56%
Number Object Access (Execution) 3.9±0.10µs 3.9±0.11µs 0.00%
Number Object Access (Full) 283.3±7.67µs 277.1±9.54µs +2.24%
Object Creation (Execution) 5.4±0.21µs 5.3±0.14µs +1.89%
Object Creation (Full) 283.5±8.95µs 275.3±12.34µs +2.98%
RegExp (Execution) 10.1±0.33µs 10.3±0.32µs -1.94%
RegExp (Full) 295.5±12.94µs 279.3±7.84µs +5.80%
RegExp Literal (Execution) 11.3±0.39µs 11.4±1.17µs -0.88%
RegExp Literal (Full) 296.2±10.19µs 290.3±10.70µs +2.03%
RegExp Literal Creation (Execution) 10.1±0.17µs 10.1±0.33µs 0.00%
RegExp Literal Creation (Full) 289.3±8.55µs 276.1±7.36µs +4.78%
Static Object Property Access (Execution) 5.7±0.43µs 5.5±0.09µs +3.64%
Static Object Property Access (Full) 289.4±9.27µs 277.8±7.39µs +4.18%
String Object Access (Execution) 7.5±0.21µs 7.9±0.60µs -5.06%
String Object Access (Full) 287.6±10.52µs 277.2±7.80µs +3.75%
String comparison (Execution) 7.1±0.18µs 7.1±0.28µs 0.00%
String comparison (Full) 284.3±8.83µs 278.5±8.44µs +2.08%
String concatenation (Execution) 5.7±0.15µs 5.9±0.20µs -3.39%
String concatenation (Full) 281.6±11.21µs 269.6±5.23µs +4.45%
String copy (Execution) 4.5±0.16µs 4.5±0.12µs 0.00%
String copy (Full) 271.7±9.51µs 265.3±8.73µs +2.41%
Symbols (Execution) 3.8±0.11µs 3.9±0.22µs -2.56%
Symbols (Full) 260.8±6.77µs 251.2±15.10µs +3.82%

@HalidOdat HalidOdat merged commit 9a295fe into master Oct 14, 2020
@HalidOdat HalidOdat deleted the no_macos_cache branch October 14, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants