Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BigInt.prototype.toString() radix checks #885

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Fix BigInt.prototype.toString() radix checks #885

merged 1 commit into from
Oct 17, 2020

Conversation

georgeroman
Copy link
Contributor

Fixes some radix panics from #817

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #885 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   59.29%   59.30%   +0.01%     
==========================================
  Files         165      165              
  Lines       10376    10376              
==========================================
+ Hits         6152     6154       +2     
+ Misses       4224     4222       -2
Impacted Files Coverage Δ
boa/src/builtins/bigint/mod.rs 66.66% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb2442...b2ed3b6. Read the comment docs.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Oct 17, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 17, 2020
@HalidOdat HalidOdat changed the title Fix BigInt.toString radix checks Fix BigInt.prototype.toString() radix checks Oct 17, 2020
@HalidOdat HalidOdat merged commit 71bc080 into boa-dev:master Oct 17, 2020
Razican
Razican approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@georgeroman @Razican @HalidOdat