implements toLowerCase, toUpperCase, substring, substr and valueOf St… #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @arbroween looks good, are you able to rebase? |
|
ping @arbroween |
…ring prototype methods
jasonwilliams
force-pushed
the
string-prototype-methods
branch
from
ab47eed to
6950ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ring prototype methods
Hey there !
I implemented toLowerCase, toUpperCase, substring, substr and valueOf, to get more familiar with the code base as suggested on the project Discord. They are part of #13.
This is my first PR and also I am not an expert in Rust, but I tried to implement the algorithms in the tc39 specification as much as I could and I also followed the style of the already implemented String prototype methods.
I don't know if the implementation semantics are exactly the ones expected, but they should be close.
Any feedback is very welcomed!
Tell me if there is something I can improve