Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement String.prototype.codePointAt #935

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

devinus
Copy link
Contributor

@devinus devinus commented Nov 18, 2020

This Pull Request fixes/closes #751.

It changes the following:

  • Adds String.prototype.codePointAt
  • Adds a few more tests
  • Fixes two Clippy linting suggestions

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #935 (2731524) into master (7f5868b) will decrease coverage by 0.01%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   59.21%   59.20%   -0.02%     
==========================================
  Files         166      166              
  Lines       10554    10563       +9     
==========================================
+ Hits         6250     6254       +4     
- Misses       4304     4309       +5     
Impacted Files Coverage Δ
boa/src/builtins/string/mod.rs 61.47% <70.83%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5868b...1dd0942. Read the comment docs.

@devinus devinus force-pushed the string-codepointat branch 2 times, most recently from 5838d85 to 9a826d8 Compare November 18, 2020 02:14
Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good, there was some nearby code that I was a bit confused by that I'd like another mantainer to check on.

boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@devinus
Copy link
Contributor Author

devinus commented Nov 19, 2020

Just as a heads-up, I tried testing corner cases around unpaired surrogates until I realized that required this to be completed first: #736

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good to me :)

@Razican Razican merged commit c54c6af into boa-dev:master Nov 20, 2020
@RageKnify RageKnify added this to the v0.11.0 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement String.prototype.codePointAt
3 participants