-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unresolved links in documentation #960
Conversation
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 59.29% 59.32% +0.02%
==========================================
Files 166 166
Lines 10689 10687 -2
==========================================
+ Hits 6338 6340 +2
+ Misses 4351 4347 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This cleans up a lot of stuff in the docs :)
I only noticed two minor things that could be improved.
boa/src/syntax/ast/op.rs
Outdated
/// - [ECMAScript reference]( | ||
/// - [MDN documentation][mdn] | ||
/// | ||
/// [spec]: https://tc39.es/ecma262/#prod-LogicalORExpression) | ||
/// [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_Operators#Logical_OR | ||
/// [spec]: <https://tc39.es/ecma262/#prod-LogicalORExpression)> | ||
/// [mdn]: <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_Operators#Logical_OR> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is not correct, right? It should show [spec]
next to [ECMAScript reference]
, and then, the links should not have <...>
. Also, the spec
link should not have a closing )
Co-authored-by: Iban Eguia <razican@protonmail.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me :)
This Pull Request fixes #957.
It changes the following: