Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests that can be failed due to daylight saving time #968

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix unit tests that can be failed due to daylight saving time #968

merged 1 commit into from
Dec 16, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 15, 2020

This Pull Request fixes #967.

It changes the following:

  • Unit tests date_proto_to_time_string and date_proto_to_string

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #968 (66fc4cd) into master (8f388d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         166      166           
  Lines       10717    10717           
=======================================
  Hits         6366     6366           
  Misses       4351     4351           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f388d5...a756ba0. Read the comment docs.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :) this solves the issue, yes.

@Razican Razican added this to the v0.11.0 milestone Dec 16, 2020
@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Dec 16, 2020
@RageKnify RageKnify merged commit a6ec41e into boa-dev:master Dec 16, 2020
@tofpie tofpie deleted the fix-date-test branch December 16, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some unit tests fail in a timezone with Daylight Saving Time
3 participants