Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enumerable attribute on string length property #974

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Fix enumerable attribute on string length property #974

merged 3 commits into from
Dec 18, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 16, 2020

This Pull Request fixes #973.

It changes the following:

  • The length property of a string is set to non enumerable

@codecov
Copy link

codecov bot commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #974 (f26bfac) into master (b058b2d) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   59.56%   59.56%   -0.01%     
==========================================
  Files         166      166              
  Lines       10815    10819       +4     
==========================================
+ Hits         6442     6444       +2     
- Misses       4373     4375       +2
Impacted Files Coverage Δ
boa/src/builtins/string/mod.rs 61.33% <66.66%> (-0.14%) ⬇️
boa/src/value/mod.rs 74.27% <75.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b058b2d...bafe3dc. Read the comment docs.

RageKnify
RageKnify suggested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@RageKnify RageKnify left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing these lines might as well remove the unnecessary conversion.

boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@RageKnify RageKnify added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Dec 16, 2020
@tofpie tofpie mentioned this pull request Dec 16, 2020
Merged
@Razican Razican added this to the v0.11.0 milestone Dec 17, 2020
@Razican Razican requested a review from RageKnify December 17, 2020 08:17
@Razican
Copy link
Member

Razican commented Dec 17, 2020 •
edited
Loading

This looks good :)

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,392 19,400 +8
Ignored 15,585 15,585 0
Failed 43,516 43,508 -8
Panics 447 447 0
Conformance 24.71 24.72 +0.01%

RageKnify
RageKnify reviewed Dec 17, 2020
View reviewed changes
boa/src/value/mod.rs Outdated Show resolved Hide resolved
@Razican Razican added the blocked Waiting for another code change label Dec 17, 2020
@Razican
Copy link
Member

Razican commented Dec 17, 2020

This is blocked on #977.

@Razican Razican removed the blocked Waiting for another code change label Dec 18, 2020
@Razican
Copy link
Member

Razican commented Dec 18, 2020

#977 was merged, could you rebase?

@RageKnify RageKnify merged commit d46080d into boa-dev:master Dec 18, 2020
@tofpie tofpie deleted the fix-973 branch December 18, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@RageKnify RageKnify RageKnify approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

The length property of a string is enumerable
3 participants
@tofpie @Razican @RageKnify