Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to add feature flags for a benchmark #32

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

1c3t3a
Copy link
Contributor

@1c3t3a 1c3t3a commented Feb 2, 2022

This PR adds the possibility to add a feature flag for the execution of a benchmark. Basically it provides a possibility for a call similar to this one:

cargo bench --features async,tokio-support

A further cargo bench flag that is similar to this change is the --no-default-features flag.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!! Thanks for the contribution! It looks pretty good :) this will need you to run npm run build so that it generates the distributable :)

@1c3t3a
Copy link
Contributor Author

1c3t3a commented Feb 3, 2022

Alright great! I amended the changes and force pushed ;)

@Razican Razican merged commit 4a46bfa into boa-dev:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants