-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream/master
#21
Conversation
- run: cargo miri test | ||
env: | ||
MIRIFLAGS: "-Zmiri-tag-raw-pointers" | ||
MIRIFLAGS: -Zmiri-strict-provenance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that they are using miri here, maybe we could also use it in Boa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so too maybe it could catch some hard to find bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open an issue about this
env: | ||
RUSTFLAGS: -Dwarnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could maybe be added to Boa too, to avoid having warnings in the repo.
8f5c3ec
to
fd2f25e
Compare
Co-authored-by: Aphek <bilkow@tutanota.com>
No description provided.