Implement Duration normalization - Part 1
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
duration-normalization
branch
from
e7f92f0 to
08f7251
Compare
nekevss
force-pushed
the
duration-normalization
branch
from
08f7251 to
2218d49
Compare
nekevss
changed the title
Duration normalizationDuration normalization - Part 1
|
I'm seeing the spec corrections make it possible to do the computations using 128bit integers. Will we transition to that representation in the future? (32 bit components + 128 bit normalized repr) |
|
Yeah, I think it did. To be frank, I haven't put too much thought into it as of yet. Mostly because I would really like to have a lot more of the spec implemented and some more tests in place to mitigate any edge cases or oddities that may arise off the switch. Since |
jedel1043
approved these changes
Feb 14, 2024
jedel1043
approved these changes
Feb 14, 2024
jedel1043
force-pushed
the
duration-normalization
branch
from
65b4a84 to
daaae7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is meant to eventually address #19
Currently, this PR is small baseline changes focused on
NormativeTimerecords andbalancemethods (EDIT: it also addsCalendarDateAddfunctionality for theISO8601).The changes overall are pretty widespread across large sections ofDurationthat could really use more tests, so the plan is to come back to this once it can be tested a bit more or split it into a couple of PRs.I'm going to switch this into a normal PR from a draft. After looking through it, #19 will still need to be implemented in a couple PRs, but I think it makes more sense to break the overall update down into smaller chunks