fix #159, simplify setType and stackType in codegen

boalang · Jan 22, 2018 · 081e731 · psybers · Jan 22, 2018 · 081e731
1 parent b263206
commit 081e731
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 22 deletions.
diff --git a/src/java/boa/compiler/visitors/CodeGeneratingVisitor.java b/src/java/boa/compiler/visitors/CodeGeneratingVisitor.java
@@ -1872,31 +1872,20 @@ public void visit(final OutputType n) {
 	/** {@inheritDoc} */
 	@Override
 	public void visit(final StackType n) {
-		final ST st = stg.getInstanceOf("StackType");
-
-		n.env.setNeedsBoxing(true);
-
-		n.getValue().accept(this);
-		st.add("value", code.removeLast());
-
-		n.env.setNeedsBoxing(false);
-
-		code.add(st.render());
+		if(n.type != null)
+			code.add(n.type.toJavaType());
+		else{
+			final ST st = stg.getInstanceOf("StackType");
+			n.getValue().accept(this);
+			st.add("value", code.removeLast());
+			code.add(st.render());
+		}
 	}
 
 	/** {@inheritDoc} */
 	@Override
 	public void visit(final SetType n) {
-		final ST st = stg.getInstanceOf("SetType");
-
-		n.env.setNeedsBoxing(true);
-
-		n.getValue().accept(this);
-		st.add("value", code.removeLast());
-
-		n.env.setNeedsBoxing(false);
-
-		code.add(st.render());
+		code.add(n.type.toJavaType());
 	}
 
 	/** {@inheritDoc} */

diff --git a/templates/BoaJava.stg b/templates/BoaJava.stg
@@ -18,9 +18,7 @@ identifierMap ::= [
 
 VarDecl(isstatic, type, id) ::= "<if(isstatic)>static <endif><type> ___<id>;<\n>"
 ArrayType(type) ::= "<type>[]"
-MapType(key, value) ::= "java.util.HashMap\<<key>, <value>>"
 StackType(value) ::= "java.util.Stack\<<value>>"
-SetType(value) ::= "java.util.LinkedHashSet\<<value>>"
 Block(statements) ::= <<
 {
 	<statements:{s | <s>}>}