Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: testnet update #108

Merged
merged 8 commits into from
Dec 13, 2023
Merged

docs: testnet update #108

merged 8 commits into from
Dec 13, 2023

Conversation

nud3l
Copy link
Contributor

@nud3l nud3l commented Dec 7, 2023

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 8:23am

nud3l
nud3l commented Dec 11, 2023
View reviewed changes
docs/docs/build/getting-started/networks.md Outdated Show resolved Hide resolved
docs/docs/build/contracts/index.md Outdated Show resolved Hide resolved
docs/docs/build/contracts/index.md Outdated Show resolved Hide resolved
docs/docs/build/contracts/index.md Outdated Show resolved Hide resolved
@nud3l nud3l changed the title docs: WIP testnet update docs: testnet update Dec 13, 2023
@nud3l
Copy link
Contributor Author

nud3l commented Dec 13, 2023

This looks good to me. Anything else we should add?

@tomjeatt
Copy link
Contributor

tomjeatt commented Dec 13, 2023 •
edited
Loading

This looks good to me. Anything else we should add?

No, I think that's it—I've been through the docs this morning and can't see anything else that needs updating. Only thing left to do is update the README files in the demos, to make sure the contract addresses, links etc. are all correct. Once I've done that I'll double check that everything matches up, and then we can merge this in.

Edit: also waiting on @danielsimao to review the wallet page, but that's the last known change :)

@tomjeatt
Copy link
Contributor

Merging this in now—may be some small changes depending on how testing goes over the next day or two, but the bulk of the changes are done.

@tomjeatt tomjeatt merged commit a2d1f28 into master Dec 13, 2023
2 checks passed
@tomjeatt tomjeatt deleted the dom/new-testnet branch December 13, 2023 11:21
@nud3l
Copy link
Contributor Author

nud3l commented Dec 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill left review comments

@sander2 sander2 sander2 left review comments

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nud3l @tomjeatt @sander2 @gregdhill