-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Classic block - buttons insert shortcodes at start of post #100
Comments
In v4.0.0 the buttons do appear to work on some devices but not at all on others.
On the iPad, the only evidence that something was attempted is a scrolling barbershop pole which appears if you scroll the page down and the admin bar appears to have dropped down a bit as well. |
The Add media button does work. So there’s some hope. |
With WordPress 5.0-beta5, Gutenberg 4.4, Classic Editor 0.5 the buttons no longer do anything on my new laptop running Edge. oik v3.2.5 |
The barbershop pole is created by the thick box Javascript code. We should retest with Gutenberg 4.0.0 to attempt to rediscover a version that ‘worked’ on laptops. Then, perhaps, update this comment. |
I ran parallel Javascript debugging tests of the working version on
The buttons now work, but insertion where the cursor is located is still iffy. |
This problem was resolved with WordPress/gutenberg#12415 |
With the Gutenberg plugin, the Classic block editor can be used to create content as if you were in the TinyMCE editor.
The three different buttons that oik provides work unchanged, except for the last bit where the generated shortcode is pasted into the editor at the cursor position.
Expected result
The shortcode is pasted at the cursor position
Actual result
The shortcode is pasted at the start of the block
Explanation
The logic needs to cater for the fact that there could be multiple blocks.
It's currently using
Changing this one line to
seemed to fix the problem for the button creator dialog and it appeared to work for both the new editor and the Classic editor ( which was nice ).
BUT... It doesn't work and I have very little idea what I need to do to fix it.
Problem determination
Whatever I seem to do it works fine in the Classic Editor but fails in the Classic block.
The text was updated successfully, but these errors were encountered: