Fastapi backend #65
Fastapi backend #65
Conversation
|
wow, will take a deep look soon! |
| app = fastapi.FastAPI() | ||
|
|
||
| # init the logger as usual | ||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
you're missing the logger.setLevel call
There was a problem hiding this comment.
This is actually not necessary. All what's needed is configured further down with a config dict.
I'm doing it that way, so that I can pass this configuration to uvicorn which configures logging itself. When I tried it locally in the script as for the other backends it didn't work out.
There was a problem hiding this comment.
a bit weird, when i run the sample directly from terminal the logging statement didnt emit anything, only works with setLevel call
There was a problem hiding this comment.
Ah, when you copy the code directly into an IPython shell, you mean? I also tested it and indeed that didn't work without logger.setLevel(). I only tested to run the script as dedicated python process (python fastapi_sample_app.py).
But right, with an additional logger.SetLevel() it works under all circumstances, so I just added that.
| return False | ||
|
|
||
|
|
||
| if is_fastapi_present(): |
There was a problem hiding this comment.
No, the second one is an if statement using the function. This pattern I adopted from other backends.
But your comment reminds me of this mechanism and that I did not stick to the lazy importing it was for. I have to adjust the way I do the imports. Otherwise json-logging can only be used if fastapi is installed.
Will take me the one or other day until I find the time.
Thanks for pointing me at it!
There was a problem hiding this comment.
its total fine, somehow i misunderstood it LOL
|
@bobbui, as I wrote above your comment made me aware that the fastapi implementation always imported In order to guarantee that such things are caught by the tests in the future I added another test suite which runs all the examples from the README file in a minimal environment for the respective backend. E.g. the flask backend is only run in an environment with "flask" and the test tooling in it. That's the reason why I had to make it a separte job in the github action workflow. A more elegant solution did not come to my mind. |
Its should be ok that way even though a bit undesirable. The integration test approach is sound, if we can somehow run each sample in a minimal isolated environment, e.g: Flask sample only run with Python virtualenv with only Flask installed. That would be really great. |
Only then it works in the IPython shell
That's just what I implemented in |
|
released 1.3.0 |
This PR adds a backend for Fastapi including tests and example.
In the first commits there are also fixes for