Skip to content

Commit

Permalink
*: golint (part 1)
Browse files Browse the repository at this point in the history
  • Loading branch information
mdlayher committed Jan 7, 2016
1 parent 42c8b50 commit b348482
Show file tree
Hide file tree
Showing 10 changed files with 286 additions and 290 deletions.
12 changes: 6 additions & 6 deletions attrs.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ type FileStat struct {
Mode uint32
Mtime uint32
Atime uint32
Uid uint32
Gid uint32
UID uint32
GID uint32
Extended []StatExtended
}

Expand Down Expand Up @@ -98,10 +98,10 @@ func unmarshalAttrs(b []byte) (*FileStat, []byte) {
fs.Size, b = unmarshalUint64(b)
}
if flags&ssh_FILEXFER_ATTR_UIDGID == ssh_FILEXFER_ATTR_UIDGID {
fs.Uid, b = unmarshalUint32(b)
fs.UID, b = unmarshalUint32(b)
}
if flags&ssh_FILEXFER_ATTR_UIDGID == ssh_FILEXFER_ATTR_UIDGID {
fs.Gid, b = unmarshalUint32(b)
fs.GID, b = unmarshalUint32(b)
}
if flags&ssh_FILEXFER_ATTR_PERMISSIONS == ssh_FILEXFER_ATTR_PERMISSIONS {
fs.Mode, b = unmarshalUint32(b)
Expand Down Expand Up @@ -149,8 +149,8 @@ func marshalFileInfo(b []byte, fi os.FileInfo) []byte {
b = marshalUint64(b, fileStat.Size)
}
if flags&ssh_FILEXFER_ATTR_UIDGID != 0 {
b = marshalUint32(b, fileStat.Uid)
b = marshalUint32(b, fileStat.Gid)
b = marshalUint32(b, fileStat.UID)
b = marshalUint32(b, fileStat.GID)
}
if flags&ssh_FILEXFER_ATTR_PERMISSIONS != 0 {
b = marshalUint32(b, fileStat.Mode)
Expand Down
2 changes: 1 addition & 1 deletion attrs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ var unmarshalAttrsTests = []struct {
{marshal(nil, struct {
Flags uint32
Size uint64
Uid, Gid, Permissions uint32
UID, GID, Permissions uint32
}{ssh_FILEXFER_ATTR_SIZE | ssh_FILEXFER_ATTR_UIDGID | ssh_FILEXFER_ATTR_UIDGID | ssh_FILEXFER_ATTR_PERMISSIONS, 20, 1000, 1000, 0644}), &fileInfo{size: 20, mode: os.FileMode(0644), mtime: time.Unix(int64(0), 0)}, nil},
}

Expand Down
4 changes: 2 additions & 2 deletions attrs_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
func fileStatFromInfoOs(fi os.FileInfo, flags *uint32, fileStat *FileStat) {
if statt, ok := fi.Sys().(*syscall.Stat_t); ok {
*flags |= ssh_FILEXFER_ATTR_UIDGID
fileStat.Uid = statt.Uid
fileStat.Gid = statt.Gid
fileStat.UID = statt.Uid
fileStat.GID = statt.Gid
}
}
Loading

0 comments on commit b348482

Please sign in to comment.