Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments about the performance of some methods #20

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

bobg
Copy link
Owner

@bobg bobg commented Aug 1, 2024

This PR adds comments about the performance of some methods, as suggested in #19.

Copy link

github-actions bot commented Aug 1, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's patchlevel.

checking sliceIter
  old and new versions of github.com/bobg/go-generics/v3/iter.sliceIter[S ~[]T, T any] are not identical
    Patchlevel

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10190862711

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.854%

Totals Coverage Status
Change from base Build 10021976838: 0.0%
Covered Lines: 1056
Relevant Lines: 1202

💛 - Coveralls

@bobg bobg merged commit c47090b into master Aug 1, 2024
2 checks passed
@bobg bobg deleted the bobg/perf-comments branch August 1, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants