WIP: integrate test cases from the hashsplit org test suite. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't pass; unsurprising.
...rather than picking whatever the stdlib's rng gives us. This doesn't actually fix the tests; most likely the buzhash32 implementation isn't exactly cp32, which is unsurprising.
This now exists at #5 ! I'd be very grateful if you'd take a look. Any chance of getting some test vectors for the cp32 algorithm? Please note that since you originally wrote this pull request (for which, a very belated thank you), I have dramatically redesigned the API around Go's new iterator feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
It doesn't work, and this should not be merged as-is. But, either we should fix it, or fix the spec, or at least not claim within the README that this is an implementation of what's in the spec.
I suspect the buzhash32 from the library you're using isn't exactly what we specified as cp32. The easiest path may be to just implement it directly.
Note also that the test configs have a maxSize field, which doesn't seem to have an analogue in this library.