fix(delete-env): proper warning on 404 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we get a 404 deleting an environment there should be a better warning than "unexpected error encountered: HttpError: Not Found" Document in the readme that the user for the PAT must have admin on the repo, not just write or manage.
|
Thanks for the PR. |
|
@mtfurlan I've been strugging with getting delete-env to work. Does this work with fine-grained personal access tokens or just the classic tokens? |
|
Yeah, this repo works with PATs, but as I have in the readme change, the PAT needs repo scope permissions, and the owner of the PAT needs to be admin on the repo. |
bobheadxi
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get a 404 deleting an environment there should be a better
warning than "unexpected error encountered: HttpError: Not Found"
Document in the readme that the user for the PAT must have admin on the
repo, not just write or manage.