Merge pull request howdyai#1979 from ashitikov/channelData-replace-fix

Fix channelData replace in conversations
bobisai · Aug 21, 2020 · 74da283 · 74da283
2 parents 85e052f + e436cbe
commit 74da283
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/botkit/src/conversation.ts b/packages/botkit/src/conversation.ts
@@ -857,8 +857,13 @@ export class BotkitConversation<O extends object = {}> extends Dialog<O> {
         }
 
         // copy all the values in channelData fields
-        for (const key in line.channelData) {
-            outgoing.channelData = this.parseTemplatesRecursive(JSON.parse(JSON.stringify(line.channelData)), vars)
+        if (line.channelData && Object.keys(line.channelData).length > 0) {
+            const channelDataParsed = this.parseTemplatesRecursive(JSON.parse(JSON.stringify(line.channelData)), vars);
+
+            outgoing.channelData = {
+                ...outgoing.channelData,
+                ...channelDataParsed
+            };
         }
 
         /*******************************************************************************************************************/