Add support for Mongoose@5 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull! Published on npm |
tourbillonlabs
pushed a commit
to tourbillonlabs/react-native-parse-cache
that referenced
this pull request
Aug 14, 2019
* Upgrade deps to latest releases * Add --exit flag to test script (required since mocha@4 - https://boneskull.com/mocha-v4-nears-release/#mochawontforceexit) * Use native promises instead of mongoose Promise.ES6 (not provided in mongoose@5 anymore - Automattic/mongoose#2917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongoose v5 was released last week and they dropped support for their custom Promise implementation (ie,
mongoose.Promise.ES6is undefined, we need to use native promises instead).Updated other deps to latest releases too.
It should certainly be tagged as a new breaking change major version as it won't work anymore with older Node.js version (