Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline rubygems patch to fix sha mismatch #12

Closed
wants to merge 1 commit into from

Conversation

will
Copy link
Contributor

@will will commented Dec 14, 2022

It's strange to me that the nix sha could change for the same patch, but it's small enough I figure it'd be easier to inline it to the repo rather than pull it down to make sure it doesn't happen again

Fixes #11

@thecatwasnot
Copy link

I found it strange too. I forked and changed the sha to test, no further issues that way but this seems better. Thanks!

@bobvanderlinden
Copy link
Owner

I personally do like having the patch files referenced by fetching them from an url. It gives a bit more context where these patches come from. I'd like to avoid having a large number of patch files in the repo if they were sourced/copied from somewhere else.

#23 made quite a few changes to the project. It is now fetching raw patch files from the nixpkgs repository. I'm still not 100% sure why the hashes have changed, but I suspect it has something to do with fetchpatch using various tools internally that might have been upgraded and now give an output in a backwards incompatible way. I didn't notice the change in hash, as it was already built locally unfortunately.

Would it then be better to use fetchurl instead of fetchpatch?

@will will closed this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash mismatch in fixed-output derivation
3 participants