Use harness as published to NPM #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisC
approved these changes
Feb 13, 2025
gnarf
reviewed
Feb 13, 2025
| ref: "main" | ||
| path: "aria-at-automation-harness" | ||
| - name: Install the ARIA-AT Automation Harness package | ||
| run: npm install aria-at-automation-harness@"~0.0.1" |
There was a problem hiding this comment.
Curious if you think it'd be worth parameterizing the version for the harness
There was a problem hiding this comment.
I'd rather wait till we need it
|
I just merged w3c/aria-at-automation-harness#75 and published the harness to npm, so this is ready to go! |
jugglinmike
added a commit
that referenced
this pull request
Feb 20, 2025
This reverts commit 917aa1c. The reverted commit caused issues in the Windows/NVDA GitHub Action, where the following error was reported by `run-tester.ps1`: Launching automation-harness host D:\a\aria-at-gh-actions-helper\aria-at-gh-actions-helper\node_modules\.bin\aria-at-harness-host:2 basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')") ^^^^^^^ SyntaxError: missing ) after argument list at wrapSafe (node:internal/modules/cjs/loader:1378:20) at Module._compile (node:internal/modules/cjs/loader:1428:41) at Module._extensions..js (node:internal/modules/cjs/loader:1548:10) at Module.load (node:internal/modules/cjs/loader:1288:32) at Module._load (node:internal/modules/cjs/loader:1104:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12) at node:internal/main/run_main_module:28:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on w3c/aria-at-automation-harness#75