-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pooling of decompressed folder readers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* noopPool doesn't store anything and automatically closes the passed SizeReadSeekCloser. * pool maintains a fixed number of SizeReadSeekCloser's based on their offset using an LRU strategy.
Implement Size and Seek methods. Seek can only seek forward in the file.
When calling Open on a File, the associated pool is used to find an existing SizeReadSeekCloser for the underlying stream. The Close method attempts to put the underlying SizeReadSeekCloser back in the pool if it's not yet at the end of the stream.
Contains lots of files with a mix of compression methods.
Also fix cyclop, funlen, gochecknoglobals, gochecknoinits, gocognit & gocyclo lint warnings.
Not sure it was doing anything useful. Make the passed reader implement io.ByteReader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming the common use case:
Comparing performance using the
noopPool
implementation (which doesn't pool so it's identical to the original behaviour) and thepool
implementation:The complex benchmark uses the 7-Zip/LZMA SDK archive which contains 633 files using a mix of compression methods. Reading this entire archive goes from taking 35.4 seconds to just 0.2 seconds!
The copy decompressor is the only one that doesn't improve (unsurprisingly) as it doesn't transform the bytes in any way.
Fixes #22