Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy.toml to work on both stable and nighly toolchains #82

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Update clippy.toml to work on both stable and nighly toolchains #82

merged 1 commit into from
Apr 8, 2019

Conversation

pzmarzly
Copy link
Contributor

@pzmarzly pzmarzly commented Apr 7, 2019

On clippy 0.0.212 (92612c9 2019-03-18):

error: error reading Clippy's configuration file `/home/pzmarzly/im-rs/clippy.toml`: found deprecated field `cyclomatic-complexity-threshold`. Please use `cognitive-complexity-threshold` instead.

Renaming the field makes clippy happy both on 0.0.212 (92612c9 2019-03-18) (nightly) and 0.0.212 (1b89724 2019-01-15) (stable).

@pzmarzly
Copy link
Contributor Author

pzmarzly commented Apr 7, 2019

Never mind, cognitive-complexity-threshold doesn't work on stable (why did it work for me? dunno, deleted the directory already). I guess clippy on stable is more important to you than clippy on nightly, so feel free to close that PR.

But on the other hand, is this flag even necessary? Let me try removing it

@pzmarzly
Copy link
Contributor Author

pzmarzly commented Apr 7, 2019

Seem to be working fine without cyclomatic-complexity-threshold and cognitive-complexity-threshold. Squashing...

@bodil
Copy link
Owner

bodil commented Apr 8, 2019

It's just part of my standard Clippy config, I have a few other projects where it's necessary pending rust-lang/rust-clippy#3900. I've got no problem with removing it from im.

@bodil bodil merged commit 1b19e53 into bodil:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants