Fix soundness issues in sized chunks and ringbuffer #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit, pair and From<InlineArray> now check the capacity, because one could create 0-capacity or small capacity arrays.
vorner
changed the title
vorner
force-pushed
the
check-min-size
branch
2 times, most recently
from
4444694 to
9668113
Compare
Panic safety in the insert_from and Clone. The insert_from leaks elements in case of panic. This is more of a quickfix than proper solutions :-(.
kornelski
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (hopefully) part of #11, + something I've seen on the way.
I'm not entirely sure if this is the right way:
unitandpairmethods compile-time unavailable on too small arrays, instead of panicking. I don't worry about the performance (the check should be optimized out, as both numbers are constants at compile time), but the user would get the error sooner. On the other hand, some kind of generic code would have harder time, because it would also have to declare the same trait bounds as I'd have added and they won't be exactly nice. So I'm not sure if it's worth it.I'll have a look at the InlineArray in a separate pull request.