BSE-4403: Fix hdf5 import #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njriasan
approved these changes
Jan 6, 2025
srilman
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage ? 77.85%
=======================================
Files ? 160
Lines ? 62064
Branches ? 8769
=======================================
Hits ? 48318
Misses ? 11622
Partials ? 2124 |
DrTodd13
pushed a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
The import path for the hdf5 module changed and needed to be updated, also the CMake logic around NO_HDF5 was simplified.
Testing strategy
bodo/tests/test_basic.py::test_pure_func locally and PR CI
User facing changes
NA
Checklist
[run CI]in your commit message.