Move intervalToNanos out of the Calcite files and into our parser utils functions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWarren
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage ? 77.84%
=======================================
Files ? 160
Lines ? 62064
Branches ? 8769
=======================================
Hits ? 48312
Misses ? 11626
Partials ? 2126 |
scott-routledge2
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Changes to
SqlParserUtil.javashould only be those breaking changes that we need to back port into importing Calcite (and should only be done when we do not actively include all uses of the file already in our source code). SinceintervalToNanos, which is meant to replace theintervalToMilliin Calcite requires a new function signature, every usage must exist inside our source code, so it should existing our extension files.Ideally in the future we could also remove
SqlParserUtilin general, but right now we need the remaining changes to ensure we get some default precisions because of its reuse in the validator.Testing strategy
User facing changes
Checklist
[run CI]in your commit message.