Support GCS in read_csv() #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage ? 77.87%
=======================================
Files ? 169
Lines ? 61947
Branches ? 8644
=======================================
Hits ? 48242
Misses ? 11615
Partials ? 2090 |
srilman
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
As title. Also fixes a bug in inferring compression scheme of directories of files, and some small refactoring.
Testing strategy
Added a unit test for reading from a public bucket. Tested non-public buckets manually with my own account since we don't have an organization account yet. Will open an issue to add non-public tests.
User facing changes
Just GCS support.
Checklist
[run CI]in your commit message.