BSE-4340: Spark benchmark EMR terraform #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsantn
approved these changes
Dec 12, 2024
scott-routledge2
approved these changes
Dec 12, 2024
benchmarks/spark/emr.tf
Outdated
|
|
||
| resource "aws_s3_object" "python_script" { | ||
| bucket = aws_s3_bucket.emr_bucket.id | ||
| key = "scripts/spark_nyc_taxi_preciptation.py" |
There was a problem hiding this comment.
Can we change the name of this file in this PR since I believe there was a typo originally?
Suggested change
| key = "scripts/spark_nyc_taxi_preciptation.py" | |
| key = "scripts/spark_nyc_taxi_precipitation.py" |
And change the file name too
There was a problem hiding this comment.
Good catch, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Adds terraform file and README for running spark benchmark
Testing strategy
Ran the steps in the README
User facing changes
Easy deployment and run of spark benchmark.
Checklist
[run CI]in your commit message.