Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging in __del__ functions #76

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Avoid logging in __del__ functions #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions bodo/pandas/array_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,6 @@ def __del__(self):
otherwise we do nothing because the data is already collected/deleted.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyArrayManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down Expand Up @@ -501,10 +497,6 @@ def __del__(self):
otherwise we do nothing because the data is already collected/deleted.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazySingleArrayManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down
4 changes: 0 additions & 4 deletions bodo/pandas/arrow/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,6 @@ def __del__(self):
Delete the result from workers if it exists.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyArrowExtensionArray] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down
8 changes: 0 additions & 8 deletions bodo/pandas/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,6 @@ def __del__(self):
Delete the result from the workers if it hasn't been collected yet.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyBlockManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down Expand Up @@ -437,10 +433,6 @@ def __del__(self):
Delete the result from the workers if it hasn't been collected yet.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazySingleBlockManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down
Loading