Fix code coverage CI job #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified compute_recentness_boost to handle files with identical timestamps - Files with same commit time now receive identical boost values - Fixed failing test_recentness_boost_same_time test
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves test coverage and fixes timestamp handling in the priority boost calculation system, ensuring consistent behavior for files with identical commit times.
- Modified
src/priority.rsto ensure files with identical commit timestamps receive equal boost values by grouping them together - Added comprehensive test coverage in
tests/priority_test.rsfor priority rules and recentness boost edge cases - Updated CI workflow in
.github/workflows/ci.ymlto use covdir format for coverage reporting - Fixed
test_recentness_boost_same_timetest to verify equal boost values for same-timestamp files
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+346
to
+347
| // Files with same timestamp should get same boost | ||
| assert_eq!(boosts["file1.rs"], boosts["file2.rs"]); |
There was a problem hiding this comment.
style: test_recentness_boost_same_time should also verify the actual boost value, not just equality between files
Suggested change
| // Files with same timestamp should get same boost | |
| assert_eq!(boosts["file1.rs"], boosts["file2.rs"]); | |
| // Files with same timestamp should get same boost and both should be 0 | |
| assert_eq!(boosts["file1.rs"], 0); | |
| assert_eq!(boosts["file2.rs"], 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified compute_recentness_boost to handle files with identical timestamps
Files with same commit time now receive identical boost values
Fixed failing test_recentness_boost_same_time test