Skip to content

Commit

Permalink
[SPARK-48046][K8S] Remove clock parameter from `DriverServiceFeatur…
Browse files Browse the repository at this point in the history
…eStep`

### What changes were proposed in this pull request?

This PR aims to remove `clock` parameter from `DriverServiceFeatureStep`.

### Why are the changes needed?

Since SPARK-48038, this is not used.
- apache#46276

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46284 from dongjoon-hyun/SPARK-48046.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
dongjoon-hyun committed Apr 29, 2024
1 parent d42c10d commit f781d15
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,9 @@ import org.apache.spark.deploy.k8s.{KubernetesDriverConf, SparkPod}
import org.apache.spark.deploy.k8s.Config.{KUBERNETES_DNS_LABEL_NAME_MAX_LENGTH, KUBERNETES_DRIVER_SERVICE_IP_FAMILIES, KUBERNETES_DRIVER_SERVICE_IP_FAMILY_POLICY}
import org.apache.spark.deploy.k8s.Constants._
import org.apache.spark.internal.{config, Logging}
import org.apache.spark.util.{Clock, SystemClock}

private[spark] class DriverServiceFeatureStep(
kubernetesConf: KubernetesDriverConf,
clock: Clock = new SystemClock())
kubernetesConf: KubernetesDriverConf)
extends KubernetesFeatureConfigStep with Logging {
import DriverServiceFeatureStep._

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class DriverServiceFeatureStepSuite extends SparkFunSuite {
resourceNamePrefix = Some(LONG_RESOURCE_NAME_PREFIX),
labels = DRIVER_LABELS,
clock = clock)
val configurationStep = new DriverServiceFeatureStep(kconf, clock = clock)
val configurationStep = new DriverServiceFeatureStep(kconf)
val serviceName = configurationStep
.getAdditionalKubernetesResources()
.head
Expand Down

0 comments on commit f781d15

Please sign in to comment.