Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unmarshalling of /products endpoint via custom type #118

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

GrimmiMeloni
Copy link

fix #117

@GrimmiMeloni
Copy link
Author

@andig would you mind reviewing?

products.go Show resolved Hide resolved
@GrimmiMeloni
Copy link
Author

I am completely puzzled by the issue reported by golangci-lint.
It is clearly a false positive, but I don't understand why the same flow works locally when executed via act.

@andig
Copy link
Collaborator

andig commented Nov 27, 2023

Just dont use dot imports?

@GrimmiMeloni
Copy link
Author

GrimmiMeloni commented Nov 27, 2023

Just dont use dot imports?

That's of course one way to solve this. However the dot import style is also used by the other tests in the project, and mores this is also how the authors of convey show this in their docs. At the end of the day, the code style part for sure is arguable. What's more odd though is that the linter claims an unused import, although that's incorrect. But I will cut my losses here, and just adjust accordingly.

@bogosj bogosj merged commit 2ca3c53 into bogosj:main Nov 27, 2023
@GrimmiMeloni GrimmiMeloni deleted the fix/productsNonEnergyResponse branch November 27, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetching products fails if non-energy products are present
3 participants