Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename check_all -> check_n #14

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Rename check_all -> check_n #14

merged 2 commits into from
Feb 6, 2020

Conversation

antifuchs
Copy link
Collaborator

The old name was confusing to people - it seemed like a check whether
the entire burst capacity was available. Instead, rename to check_n,
which should make the intent clear.

@antifuchs
Rename check_all -> check_n
4210485 
The old name was confusing to people - it seemed like a check whether
the entire burst capacity was available. Instead, rename to check_n,
which should make the intent clear.
@antifuchs
Copy link
Collaborator Author

This is a follow-up from #10

@antifuchs
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Feb 6, 2020
@bors @antifuchs
Merge #14
985b402 
14: Rename check_all -> check_n r=antifuchs a=antifuchs

The old name was confusing to people - it seemed like a check whether
the entire burst capacity was available. Instead, rename to check_n,
which should make the intent clear.

Co-authored-by: Andreas Fuchs <asf@boinkor.net>
@bors
Copy link
Contributor

bors bot commented Feb 6, 2020

Build succeeded

@bors bors bot merged commit f63e6e1 into master Feb 6, 2020
@bors bors bot deleted the check_n branch February 6, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antifuchs