New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI by upgrading compiler-builtins (0.1.111 -> 0.1.113) #103

Merged

byeongkeunahn merged 3 commits into boj-rs:main from byeongkeunahn:fix-ci

Jul 6, 2024

Collaborator

byeongkeunahn commented Jul 6, 2024

Previously, the basm crate defined a dummy symbol called __unordtf2 on Windows targets to temporarily mitigate the linking error (undefined external symbol(s)).
It now seems like the issue has been fixed in compiler-builtins upstream; so the temporary mitigation now leads to duplicate symbol names error in linking time.
Hence, this commit resolves the linking error by removing the temporary mitigation.

byeongkeunahn added 3 commits

July 3, 2024 20:30


          Update build-windows.yml

5034d43


          Bump compiler-builtins to 0.1.113

f485102


          CI: do not set RUSTFLAGS as env var

69b87b1

byeongkeunahn merged commit 0210b3f into boj-rs:main

8 checks passed

byeongkeunahn deleted the fix-ci branch

July 6, 2024 01:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet