-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for basm_std::math::factorize
, Writer
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodok8
changed the title
Add Documentation
Add Documentation for Jun 4, 2024
basm_std::math::factorize
, Writer
꼼꼼한 문서화 감사합니다. 리뷰사항이 전체적이어서 코멘트로 달겠습니다.
quick review라 빠진 사항이 있을 수도 있습니다. contribution을 해주셔서 감사합니다. |
확인했습니다! 곧 수정하겠습니다. (6.9. 수정) 근무지 여건이 너무 바빠져서 수정이 늦어지고 있습니다 이번 달 안에는 처리하겠습니다. 그전에는 드래프트로 돌려놓겠습니다. 죄송합니다. |
수정했습니다. |
수정 감사합니다. 리뷰 후 코멘트 내용을 다시 수정했습니다. 새로 발생한 Clippy 이슈에 따른 수정도 있습니다. 혹시 수정사항에 이상한 부분 등이 있으면 자유롭게 의견 주세요 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #93
현재 진행상황
basm_std::math::factorize
Writer